Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new sponsors to landing page #3151

Merged
merged 7 commits into from
Aug 26, 2024
Merged

Conversation

derberg
Copy link
Member

@derberg derberg commented Aug 20, 2024

HDI -> https://opencollective.com/asyncapi/contributions/781938
Route4Me -> https://opencollective.com/asyncapi/contributions/781793
Postman -> https://opencollective.com/asyncapi/contributions/780992

I've also added some extra changes to silver sponsor component to make sure we get maximum of 4 logos per line (to see 4+3, and with 5 + 2 it looked weird. I also made sure it looks fine on mobile.

before change in CSS
Screenshot 2024-08-20 at 12 27 52

after change in CSS

Screenshot 2024-08-20 at 12 28 52

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8eeef28
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66cac92c40f8fa00082601bd
😎 Deploy Preview https://deploy-preview-3151--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Aug 20, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 33
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 56

Lighthouse ran on https://deploy-preview-3151--asyncapi-website.netlify.app/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have the sponsors' logo in SVG or WEBP format?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm taking what they have, and do not feel comfortable doing any edits, that could affect quality of the brand colors. Other logos are also not always svg. These are super small files

@akshatnema
Copy link
Member

image

@derberg Your CSS changes have made increased the size of logos abruptly in the mobile view

@derberg
Copy link
Member Author

derberg commented Aug 22, 2024

you're right, one change too much - fixed and checked locally

@akshatnema
Copy link
Member

image

HDI logo size is way too huge as compared to others, so probably we have to built a component that restricts the logo size with fixed dimension.

@derberg Can you please create an issue for this to normalize the logos of sponsors in the website?

@sambhavgupta0705
Copy link
Member

HDI logo size is way too huge as compared to others, so probably we have to built a component that restricts the logo size with fixed dimension.

Yes on mobile view its size is very big

@derberg
Copy link
Member Author

derberg commented Aug 26, 2024

@akshatnema on it

please approve this pr so we can merge the change, one of sponsors is pushing a bit

@derberg
Copy link
Member Author

derberg commented Aug 26, 2024

#3158

Copy link
Member

@Mayaleeeee Mayaleeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve this pr, and then we can reduce the size of the logos in a follow-up issue.

@akshatnema
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit c3f18c5 into asyncapi:master Aug 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants