Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure storybook theme #3152

Merged
merged 10 commits into from
Aug 30, 2024

Conversation

devilkiller-ag
Copy link
Member

Description

  • added asyncapi brand info to storybook (icon, website link, name)
  • changed font

The following changes have been added but commented out due to the lack of storybook support for customizing the BG/TEXTCOLOR independently of the settings & actions bar.

  • changed menu bar color
  • changed text color

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 22c2367
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66d155029af0980008ee86a0
😎 Deploy Preview https://deploy-preview-3152--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Aug 20, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 43
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3152--asyncapi-website.netlify.app/

@akshatnema akshatnema added the gsoc This label should be used for issues or discussions related to ideas for Google Summer of Code label Aug 21, 2024
akshatnema
akshatnema previously approved these changes Aug 29, 2024
Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@devilkiller-ag Can't we have this default dark sidebar with only logo changed?

@devilkiller-ag
Copy link
Member Author

devilkiller-ag commented Aug 29, 2024

@devilkiller-ag Can't we have this default dark sidebar with only logo changed?

Done

@devilkiller-ag
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit b28b29b into asyncapi:master Aug 30, 2024
15 checks passed
@devilkiller-ag devilkiller-ag deleted the storybook-theme branch September 15, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc This label should be used for issues or discussions related to ideas for Google Summer of Code ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants