feat: update tempDir paths in test #3160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishvamsinh28
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3160--asyncapi-website.netlify.app/ |
akshatnema
added
the
gsoc
| @@ -4,7 +4,7 @@ const buildCaseStudiesList = require('../../scripts/casestudies/index'); | |||
| const { yaml1,yaml2,json1,json2 } = require("../fixtures/caseStudyData"); | |||
|
|
|||
| describe('buildCaseStudiesList', () => { | |||
| const tempDir = path.join(__dirname, 'temp-test-dir'); | |||
| const tempDir = path.join(__dirname, '..', 'tempcache'); | |||
There was a problem hiding this comment.
Can't we have more elaborated name for this directory?
There was a problem hiding this comment.
Any suggestions 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the path of temporary directories that are generated during tests.