Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken link to generator github actions #3191

Closed

Conversation

lucky29-git
Copy link

@lucky29-git lucky29-git commented Sep 3, 2024

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 459b960
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66d7697ce721680008dc35cb
😎 Deploy Preview https://deploy-preview-3191--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Sep 3, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 41
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3191--asyncapi-website.netlify.app/

@DhairyaMajmudar
Copy link
Contributor

Hi @lucky29-git there's already PR opened solving the same #3071

@lucky29-git
Copy link
Author

@DhairyaMajmudar Oh I see, btw the file changed in #3071 is edit-page-config.json which is different from the 3 files I changed.
Should I revoke my PR ?

@DhairyaMajmudar
Copy link
Contributor

Yeah, correct so this PR is trying to update the internal non-working links, no need revoke it, wait until maintainers review and merge it : )

@lucky29-git
Copy link
Author

lucky29-git commented Sep 13, 2024

@sambhavgupta0705 can you please review this too?
if there are any changes left please let me know.

@sambhavgupta0705
Copy link
Member

@quetzalliwrites @TRohit20 please take a look

@sambhavgupta0705
Copy link
Member

closing this as duplicate #3217

@lucky29-git
Copy link
Author

Hey @sambhavgupta0705, I opened this PR three weeks ago, but it looks like a newer PR got merged instead. 😞 No worries, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs Bug 🐞 report]: Broken link to Generator Github Actions
4 participants