fix: run tests on branch pushes

[anshgoyalevil]

This updates the testing workflow to run tests on branch pushes. This allows the codecov to have a copy of coverage reports for base commits.

Summary by CodeRabbit

• Chores
  • Enhanced workflow configuration for Node.js pull request testing.
  • Introduced a new trigger for push events on the master branch.
  • Added a conditional step to determine workflow execution based on pull request status.
  • Maintained checks for necessary files and improved control flow for testing and release processes.

[coderabbitai]

Walkthrough

The pull request modifies the workflow configuration for Node.js pull request testing in the GitHub Actions setup. A new trigger for push events on the master branch has been added, and a conditional step named "Should Run" has been introduced to determine workflow execution based on the pull request's draft status and the actor's identity. The workflow retains checks for package.json and .nvmrc files, with subsequent steps conditioned on these checks, ensuring the workflow runs only under appropriate conditions.

Changes

File Path	Change Summary
.github/workflows/if-nodejs-pr-testing.yml	Modified to include a trigger for push events on the master branch; added "Should Run" step for conditional execution based on draft status and actor's identity; retained checks for package.json and .nvmrc; adjusted execution of steps based on the presence of these files.

Possibly related PRs

• feat: add codecov to the project #3168: The changes in this PR also modify the .github/workflows/if-nodejs-pr-testing.yml file, specifically adding steps for dependency installation, testing, and coverage reporting, which are closely related to the workflow modifications in the main PR.

Suggested labels

ready-to-merge, gsoc

Suggested reviewers

• derberg
• magicmatatjahu
• sambhavgupta0705
• akshatnema

🐰 In the land of code, where workflows play,
A new trigger hops in, brightening the day.
With checks in place, and conditions so clear,
Our tests will run smoothly, bringing us cheer!
So let’s dance with the code, let the changes unfold,
For a rabbit's delight is in stories retold! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ec62c5e and dd2c6ee.

📒 Files selected for processing (1)

• .github/workflows/if-nodejs-pr-testing.yml (1 hunks)

🧰 Additional context used

🔇 Additional comments (2)

.github/workflows/if-nodejs-pr-testing.yml (2)

7-8: LGTM: Addition of push trigger for master branch

The new trigger for push events on the master branch aligns perfectly with the PR objective. This change ensures that tests are executed not only on pull requests but also when changes are pushed directly to the master branch. This addition will help maintain code quality and provide Codecov with coverage reports for base commits, improving overall coverage tracking.

---

Line range hint 1-87: Verify the implementation of the "Should Run" step

The AI-generated summary mentions a new "Should Run" step that determines if the workflow should proceed based on the pull request's draft status and the actor's identity. However, this step is not visible in the provided annotated code.

Could you please confirm if this step has been implemented in a previous commit or if there's a discrepancy in the changes shown? If it has been implemented, it would be beneficial to review its logic to ensure it aligns with the intended workflow behavior.

To verify the existence and implementation of the "Should Run" step, please run the following script:

✅ Verification successful

Verified the presence of the "Should Run" step. No discrepancies found.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence and implementation of the "Should Run" step

# Test: Search for the "Should Run" step in the workflow file
rg --type yaml 'name:\s*Should Run' .github/workflows/if-nodejs-pr-testing.yml -A 10

Length of output: 562

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	dd2c6ee
🔍 Latest deploy log	https://app.netlify.com/sites/asyncapi-website/deploys/670fad885ea9ca000890e988
😎 Deploy Preview	https://deploy-preview-3296--asyncapi-website.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[asyncapi-bot]

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🔴 Performance	47
🟢 Accessibility	98
🟢 Best practices	92
🟢 SEO	100
🔴 PWA	33

Lighthouse ran on https://deploy-preview-3296--asyncapi-website.netlify.app/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@ec62c5e). Learn more about missing BASE report.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #3296   +/-   ##
=========================================
  Coverage          ?   53.17%           
=========================================
  Files             ?       21           
  Lines             ?      598           
  Branches          ?        0           
=========================================
  Hits              ?      318           
  Misses            ?      280           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[akshatnema]

/rtm