feat: create banner for online conf #3312
Conversation
thulieblack
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe changes involve updates to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant BannerComponent
participant YouTube
participant LinkedIn
User->>BannerComponent: Request to view banners
BannerComponent->>YouTube: Check banner availability
BannerComponent->>LinkedIn: Check banner availability
YouTube-->>BannerComponent: Return banner details
LinkedIn-->>BannerComponent: Return banner details
BannerComponent-->>User: Display updated banners
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3312--asyncapi-website.netlify.app/ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
components/campaigns/banners.ts (2)
18-18: LGTM! Consider using a constant for improved maintainability.The updated deadline aligns with the shift to an online conference. The date format is correct (ISO 8601).
Consider defining this date as a constant at the top of the file for easier maintenance:
const CFP_DEADLINE_PARIS = '2024-10-30T06:00:00Z';Then use it like this:
const cfpDeadlineParis = CFP_DEADLINE_PARIS;
23-29: LGTM! Consider updating thecityproperty for consistency.The updates accurately reflect the shift to an online conference and are consistent with the PR objectives.
For consistency, consider updating the
cityproperty to reflect both platforms:- city: 'YouTube', + city: 'YouTube & LinkedIn',This would align with the
dateLocationandeventNameproperties that mention both platforms.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- components/campaigns/banners.ts (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
components/campaigns/banners.ts (1)
18-29: Overall, the changes successfully update the banner for the online conference.The modifications effectively transform the banner from advertising an in-person event in Paris to an online conference on YouTube and LinkedIn. The deadline extension and updated event details are consistent with this change.
To ensure all references to the Paris event have been updated, please run the following script:
This will help identify any remaining references that might need updating.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3312 +/- ##
=======================================
Coverage 53.17% 53.17%
=======================================
Files 21 21
Lines 598 598
=======================================
Hits 318 318
Misses 280 280 ☔ View full report in Codecov by Sentry. |
| @@ -15,18 +15,18 @@ function shouldShowBanner(cfpDeadline: string) { | |||
| return true; | |||
| } | |||
|
|
|||
| const cfpDeadlineParis = '2024-10-12T06:00:00Z'; | |||
| const cfpDeadlineParis = '2024-10-30T06:00:00Z'; | |||
There was a problem hiding this comment.
Instead of using this variable, can you please add this inside map? It is very confusing to understand why are we giving cfpDeadlineParis deadline to every banner 😅
There was a problem hiding this comment.
I'm lost @akshatnema please explain. Oooh I used default cfpparis because it was a quick change after the Paris banner 🫣🫣🫣
Summary by CodeRabbit