Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifier fixes #4

Merged
merged 10 commits into from
Jul 3, 2024
Merged

Verifier fixes #4

merged 10 commits into from
Jul 3, 2024

Conversation

JakeSidSmith
Copy link

@JakeSidSmith JakeSidSmith commented Jun 23, 2024

Relies on #3

  • Add config to .vscode/settings.json to prevent formatting on save (affects solutions)
  • Do not gitignore .vscode directory
  • Fix assertRules check by importing the challenges from the verifier (functions cannot be sent through the .send method)
  • Ensure context is added to the verifier VM
  • Remove unnecessary context from sort challenge
  • Improved error reporting/feedback
  • Added ability to define a runBefore function to modify globals before submissions are run

@@ -99,7 +111,7 @@ process.on('message', (entry: VerifyJob<readonly Primitive[], Primitive>) => {
console.error('Verifier failed with error:', err);

process.send?.({
err: 'Your script contains an error',
err: `Your script contains an error: ${err}`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exposing the error allows exfiltrating the test data....

@almost almost merged commit c5ef41c into eslint Jul 3, 2024
1 check passed
@JakeSidSmith JakeSidSmith deleted the verifier-fixes branch July 4, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants