Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hocon reads env vars #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bertbesser
Copy link

@bertbesser bertbesser commented Dec 19, 2022

what it's about

Makes hocon incorporate environment variables into the configuration. This is a common scenario in e.g. containerized runtimes such as Kubeflow pipelines.

most important points of this PR

  • tested conda, pip, and poetry
  • tested hocon, yaml
  • tested docker images
  • out of scope: env vars in yaml (as it's not capable of reading env vars, would have to change to another lib such as pyaml-env)
  • minor fixes to the dockerfiles' command (just to make them work again, might need changes in other PRs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant