Add other dp events, and fix possible infinite digest loop #28
Conversation
|
@CapitanMorgan whoa, why the tests failed so badly ? |
|
When i check out master locally, it was already broken. So I started about trying to fix it. Edit: it appeared to be mainly due to issues with how i was running it , not sure if its because of windows or git bash. Eventually once i got it running i was able to fix them to work with the new changes locally. I still need to figure out how if possible to add something to test that the infinite digest loop doesn't still occur. At minimum i want to make a js fiddle showing what was happening when you use certain settings with the prior version. |
|
You are right. So at the time of last commit to master Travis was OK, but actually, now it does not pass. So I think 1st thing would be to sort this out and later I can think of adding new stuff. FFS, JavaScript world could not be stable for even couple of months 😠 |
|
I fixed the tests in #29 |
| @@ -25,31 +25,41 @@ | |||
| <div class="col-md-3"> | |||
| <div class="form-group"> | |||
| <div class="input-group" datetimepicker | |||
| on-change="vm.optionsTo.minDate = vm.dateFrom" | |||
| on-change="vm.onChangeDatePickerFrom()" | |||
There was a problem hiding this comment.
Please keep the old tests untouched.
- All new features are optional, so I believe the old scenarios should work?
- Please provide NEW tests for new features
| @@ -23,9 +23,7 @@ | |||
| "scripts": { | |||
| "pretest": "npm install", | |||
| "test": "(npm start > /dev/null &) && (gulp protractor)", | |||
|
|
|||
There was a problem hiding this comment.
Those changes are probably not necessary as well.
| } else if ((!d1 && d2 && (d1 === d1)) || (d1 && !d2 && (d2 === d2))){ | ||
| return false; // the d1 === d1 is to avoid NaN which is passed in iniitilization | ||
| } | ||
| return true; // return true for invald scenarios to prevent possible infinite digest loop |
There was a problem hiding this comment.
what are the invalid scenarios?
and why would you return true on isDateEqual check when they are invalid?
If properties are not date objects, or whatever is they reason why they can't be checked - I think- this method should return false.
|
So ideally I would like you to create a test scenario describing this infinite loop that would fail on current master. |
Adds the previously unimplemented items from http://eonasdan.github.io/bootstrap-datetimepicker/Events/
Fixes digest loop i mentioned in #26 and by doing so allows for the functionality desired in #26