Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue344 RA schema extension #353

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

xofolowski
Copy link
Contributor

As discussed in Slack channel and Issue 344, I thought it might be useful to have an extensible / customisable yml-schema for response activities.
Basically, a new array "details" was introduced, that can contain arbitrary variables (including additional arrays).
In RA_1000_testing.yml I am showing, how the result could look like.

Actually, it's not a huge change but grants much more flexibility. Backward compatibility is granted.

As of now, appropriate jinja2-templates have only been created for MD.

@yugoslavskiy yugoslavskiy self-assigned this Aug 23, 2021
@yugoslavskiy
Copy link
Member

yugoslavskiy commented Aug 23, 2021

Hello @xofolowski! Thank you for your continuous contribution!

Backward compatibility is granted.

Could you please confirm that it will work with the current confluence jinja templates?
As the workflow is now (in your PR) under details, it seems that it will be broken.

@xofolowski
Copy link
Contributor Author

Hi @yugoslavskiy,
I added rudimental support for details-> workflow in the Ninja templates for both, RAs and RPs.
Could you please verify?
Cheers,
XoF

@xofolowski
Copy link
Contributor Author

Hi @yugoslavskiy,
confluence rendering of the workflow section should now be fine.
Best
XoF

@yugoslavskiy
Copy link
Member

Hello @xofolowski ! Thank you very much for your contribution! Sorry for the delayed reply — having extremely busy time. Will check it it up shortly (:


{% if workflow is defined and workflow|length %}
## Workflow
**Please note:** This RA has not yet been converted to the extensible RA scheme
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xofolowski could you please tell me if this comment is still actual?

@yugoslavskiy
Copy link
Member

@xofolowski could you please restore .circleci/config.yml and .gitignore? For some reason, I cannot do that in web.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants