Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demosite down #1718

Closed
letharion opened this issue Oct 8, 2021 · 7 comments · Fixed by #2096
Closed

Demosite down #1718

letharion opened this issue Oct 8, 2021 · 7 comments · Fixed by #2096

Comments

@letharion
Copy link

letharion commented Oct 8, 2021

Problem
Following the link to the demo (https://athensresearch.github.io/athens) from the main github page, initial page load just yields:

message=Error: No matching clause: 
source=https://athensresearch.github.io/athens/js/compiled/app.js
lineno=8398
colno=15
error=Error: No matching clause: 
@hustodemon
Copy link
Contributor

Hi @letharion . What browser do you use? Since athens is an electron app, you should use chrome/chromium.

@letharion
Copy link
Author

This is using Firefox. I can confirm it works well in Chrome, but maybe there could a nicer warning than the above message to FF users?

hustodemon added a commit to hustodemon/athens that referenced this issue Oct 10, 2021
1. Display a warning when JS is disabled in the browser (previously the
   browser just displayed a blank page)
2. Display a warning for browsers other than chrome/chromium (previously
   a JS error popup was displayed). See athensresearch#1718
hustodemon added a commit to hustodemon/athens that referenced this issue Oct 10, 2021
1. Display a warning when JS is disabled in the browser (previously the
   browser just displayed a blank page)
2. Display a warning for browsers other than chrome/chromium (previously
   a JS error popup was displayed). See athensresearch#1718
@hustodemon
Copy link
Contributor

To be fair, I experienced this issue the 1st time I tried athens, too... So I created a PR proposal for basic warnings in case the browser is unsupported #1720.

@aadilayub
Copy link

aadilayub commented Jan 17, 2022

Is there a missing feature or something that prevents the app from working on Firefox? I recall previously it used to work on FF just fine.

@D-side
Copy link

D-side commented Feb 11, 2022

I second @aadilayub, it was working just fine in Firefox a couple weeks ago, and now with #1876 it now flat out refuses to.
Would it perhaps be a better idea to revert it for now and consider a less disruptive and more explanatory warning in its place?
With a message along the lines of:

You are using a browser that might not fully support this live demonstration of Athens. Since the app is built with Electron, it's only expected to run well on Chrome and other Chromium-based browsers. But browser support is not currently a goal for Athens, it's meant to be used as a standalone application.

@hustodemon
Copy link
Contributor

Hey guys, for me it never worked with Firefox and since it's an electron app, I supposed it can't even work on non-chrome-based browsers. But I might be wrong. In any case, I think it'd be great if an Athens developer could shed more light on this. Perhaps @filipesilva ?

@D-side
Copy link

D-side commented Feb 12, 2022

(Sorry in advance for the double notification, identity issues 😁)

Well, it did 🙂
So I think we're looking at a slight misdiagnosis here at the very least.
Followed up by a good fix, just for an unconfirmed problem. 🤷

At a glance given this symptom I can only hypothesize that there's a case form somewhere that didn't produce a match (here's where this is defined), so at least the origin is in the realm of ClojureScript. But where and whether it's even in Athens, I didn't get much further, so ideally it would be great to reproduce this problem and investigate the stack trace. I'd love to try, I've done some Clojure before, but my browser was totally okay with the past versions of the live demo, so I don't think I'd get the error in the first place 🤔

What I didn't try back then though, is a clean Firefox with no extensions, but I don't think I'm using any that might make it look more like Chrome. And I doubt anything of that caliber can easily bridge browser incompatibilities, though that'd be cool 😅

My understanding (fwiw) of this live demo setup is that it is more of a byproduct of Athens being based on browser tech, which is just a convenient leverage for producing a low-barrier (for lack of download & installation) live demo quickly. And when it works, it works. When it doesn't — ah, well, will have to recommend a full installation, which is a higher entry bar, but at least a full experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants