Basic warnings for unsupported browsers #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Display a warning when JS is disabled in the browser (previously the browser just displayed a blank page) 2. Display a warning for browsers other than chrome/chromium (previously a JS error popup was displayed). See athensresearch#1718
filipesilva
approved these changes
Dec 16, 2021
There was a problem hiding this comment.
Thanks for taking this on @hustodemon! I'm going to merge it now but it might be a bit until it shows up in the https://athensresearch.github.io/athens/ URL. We're not deploying it right now since it's pinned to the 1.0 release, and we're trying to avoid making a new stable release for 1.0 unless really needed.
Thanks again!
|
Awesome, thanks @filipesilva ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
browser just displayed a blank page)
a JS error popup was displayed). See Demosite down #1718