Fix docker-compose.yml

[siraht]

The docker-compose.yml file has been incorrectly formatted for the version of compose used, for months now. I've fixed it by adding dashes in front of depends_on services as well as removing the deprecated condition fields within the depends_on fields.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/athens-research/athens/HkADHNbYvarmi3MEPTwQH73V4ir4
✅ Preview: Failed

[CLAassistant]

All committers have signed the CLA.

[filipesilva]

Heya @siraht thanks for taking this on. I think something went wrong though, because the whole file shows up as new in the diff and it also shows up as a branch conflict in the merge widget.

I'm a bit confused about the file being incorrectly formatted though... I'd expect docker compose to complain about it, but I haven't seen any error messages or weird behaviour around depends_on or condition, neither locally nor on the servers we deploy to. I can see the containers waiting for each other to be in healthy states when starting too.

What version of docker and docker compose are you on? The server we run this file on is using Docker 20.10.8, and Docker Compose 1.27.4.

[filipesilva]

I can see issues that sound like what you describe in docker/compose#4538 and docker/compose#4305. I don't get any error locally or on the server though... I wonder if it's related to the platform. I'm on mac and the server is linux.

[filipesilva]

I also see mentions of it working again as of docker compose 1.27: https://news.ycombinator.com/item?id=25329651

I'm very confused about this tbh... Kind expected to find some authoritative information somewhere in the official docker channels.

[siraht]

@filipesilva sorry about the pull request issues, this was actually my first pull request ever! (And I think I know what I did wrong :P)

Anyways, with an updated Docker installation on Ubuntu (tried on multiple installations) I could not get the docker-compose working except for the configuration here.