feat(matter): add matter driver validation #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nozols
commented
Apr 17, 2024
Comment on lines
+378
to
+381
| if ( | ||
| (driver.matter.deviceVendorId === undefined && driver.matter.deviceProductName !== undefined) || | ||
| (driver.matter.deviceVendorId !== undefined && driver.matter.deviceProductName === undefined) | ||
| ) { |
There was a problem hiding this comment.
Deze waardes zijn optioneel (alleen voor bridged matter apparaten). Dus ze moeten allebei undefined zijn of allebei een waarde hebben.
RobinBol
approved these changes
Apr 17, 2024
jeroenwienk
reviewed
Apr 17, 2024
lib/App/index.js
Outdated
Comment on lines
385
to
391
| const deviceJsExists = await this._fileExistsCaseSensitive(join('drivers', driver.id, 'device.js')); | ||
|
|
||
| if (deviceJsExists) { | ||
| throw new Error(`drivers.${driver.id}: using a device.js file is not supported for Matter drivers.`); | ||
| } | ||
|
|
||
| const driverJsExists = await this._fileExistsCaseSensitive(join('drivers', driver.id, 'driver.js')); |
There was a problem hiding this comment.
Ik denk dat dit niet lekker gaat werken we hebben sowieso al .ts en straks ook .mjs. Misschien maar gewoon niet doen deze error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.