fix: add explicit security options to OAuth cookies to prevent state mismatch errors #463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Add proper security options to OAuth state and PKCE cookies
The Problem
The OAuth state and PKCE verifier cookies were being set without any explicit options, which caused two main issues:
Security vulnerabilities:
Browser compatibility:
What This PR Does:
Adds explicit cookie security options to both handleState() and handlePkceVerifier():
Why these specific options:
httpOnly: true
- Prevents JavaScript access, blocks XSS attackssecure: true
in production - HTTPS only when it matterssameSite: 'lax'
- Allows cookies during OAuth redirects while preventing CSRFmaxAge: 600
- OAuth flows should complete within 10 minutespath: '/'
- Available across the entire applicationImpact
This affects all OAuth providers in the library (GitHub, Google, Microsoft, Azure B2C, Okta, Auth0, Keycloak, etc.) since they all use these utility functions.
No breaking changes - the functions work exactly the same, just more securely.
Why
!== 'development'
instead of=== 'production'
Using the negative check means if NODE_ENV is undefined or misspelled, cookies default to secure mode. Better to have secure cookies break local dev (easy to fix) than accidentally ship insecure cookies to production.
Testing
Tested OAuth flows with several providers in both dev and production modes. The state mismatch errors are gone, and cookies are properly secured.