Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security issue #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Test! (Watch the syslog for authentication attempts)

Changelog:

- 04/Nov/2016: v0.4 Fix security fail (reported by Pat Hennessy)
- 26/Jan/2012: v0.3 Configuration file support added
- 25/Jan/2012: v0.2 CAS full user+pass combo login, and serviceValidate implemented
- 25/Jan/2012: v0.1 Initial code
Expand Down
1 change: 1 addition & 0 deletions pam_cas.c
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ int pam_sm_authenticate(pam_handle_t *pamhandle, int flags, int arg, const char
return PAM_AUTH_ERR;
}

ret = 0;
CAS_init(&cas, c.CAS_BASE_URL, c.SERVICE_URL, c.SERVICE_CALLBACK_URL);

if (c.ENABLE_ST && strncmp(pw, "ST-", 3) == 0 && strlen(pw) > MIN_TICKET_LEN) { // Possibly serviceTicket?
Expand Down