Update for Atk 4.0 #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
abbadon1334
commented
Feb 26, 2023
•
abbadon1334
commented
- Update to Atk4/Ui 4.0
- Add demo managing pages
-
- Grid MailResponses
-
- Grid MailTemplates
-
- Add/Edit MailTemplate
-
- Send New Mail
-
- Send New Mail using Template
- Strengthen ContainsOne/Many relations
Runtime: PHP 8.1.2 1) Atk4\Outbox\Tests\OutboxTest::testSend Memory leak detected! (68.781 + 68.750 + 68.750 KB, 4 iterations) 2) Atk4\Outbox\Tests\OutboxTest::testSendCallable Memory leak detected! (68.781 + 68.750 + 68.750 KB, 4 iterations) Test leakage Runtime: PHP 8.1.2 1) Atk4\Outbox\Tests\OutboxTest::testSend Memory leak detected! (68.781 + 68.750 + 68.750 KB, 4 iterations) 2) Atk4\Outbox\Tests\OutboxTest::testSendCallable Memory leak detected! (68.781 + 68.750 + 68.750 KB, 4 iterations) Test leakage Runtime: PHP 8.1.2 1) Atk4\Outbox\Tests\OutboxTest::testSend Memory leak detected! (68.781 + 68.750 + 68.750 KB, 4 iterations) 2) Atk4\Outbox\Tests\OutboxTest::testSendCallable Memory leak detected! (68.781 + 68.750 + 68.750 KB, 4 iterations) Test leakage Runtime: PHP 8.1.2 1) Atk4\Outbox\Tests\OutboxTest::testSend Memory leak detected! (68.781 + 68.750 + 68.750 KB, 4 iterations) 2) Atk4\Outbox\Tests\OutboxTest::testSendCallable Memory leak detected! (68.781 + 68.750 + 68.750 KB, 4 iterations) Test leakage Runtime: PHP 8.1.2 1) Atk4\Outbox\Tests\OutboxTest::testSend Memory leak detected! (68.781 + 68.750 + 68.750 KB, 4 iterations) 2) Atk4\Outbox\Tests\OutboxTest::testSendCallable Memory leak detected! (68.781 + 68.750 + 68.750 KB, 4 iterations) Test leakage Runtime: PHP 8.1.2 1) Atk4\Outbox\Tests\OutboxTest::testSend Memory leak detected! (68.781 + 68.750 + 68.750 KB, 4 iterations) 2) Atk4\Outbox\Tests\OutboxTest::testSendCallable Memory leak detected! (68.781 + 68.750 + 68.750 KB, 4 iterations) Test leakage Runtime: PHP 8.1.2 1) Atk4\Outbox\Tests\OutboxTest::testSend Memory leak detected! (68.781 + 68.750 + 68.750 KB, 4 iterations) 2) Atk4\Outbox\Tests\OutboxTest::testSendCallable Memory leak detected! (68.781 + 68.750 + 68.750 KB, 4 iterations)
abbadon1334
commented
Feb 27, 2023
Comment on lines
+176
to
+205
| $mlTokens = $column->addControl('_tokens', [Multiline::class], ['neverSave' => true, 'neverPersist' => true]); | ||
| $mlTokens->setModel($entityTemplate->ref('tokens')); | ||
|
|
||
| $column = $columns->addColumn(8); | ||
|
|
||
| /** @var Multiline $mlTo */ | ||
| $mlTo = $column->addControl('_to', [Multiline::class], ['neverSave' => true, 'neverPersist' => true]); | ||
| $mlTo->addClass('fluid'); | ||
| $mlTo->setModel($entityTemplate->ref('to')); | ||
|
|
||
| /** @var Multiline $mlCc */ | ||
| $mlCc = $column->addControl('_cc', [Multiline::class], ['neverSave' => true, 'neverPersist' => true]); | ||
| $mlCc->setModel($entityTemplate->ref('cc')); | ||
|
|
||
| /** @var Multiline $mlBcc */ | ||
| $mlBcc = $column->addControl('_bcc', [Multiline::class], ['neverSave' => true, 'neverPersist' => true]); | ||
| $mlBcc->setModel($entityTemplate->ref('bcc')); | ||
|
|
||
| /** @var Multiline $mlReplyTo */ | ||
| $mlReplyTo = $column->addControl('_replyto', [Multiline::class], ['neverSave' => true, 'neverPersist' => true]); | ||
| $mlReplyTo->setModel($entityTemplate->ref('replyto')); | ||
|
|
||
| $form->onSubmit(function (\Atk4\Ui\Form $form) use ($mlTo, $mlTokens, $mlCc, $mlBcc, $mlReplyTo) { | ||
| $form->model->ref('from')->save([ | ||
| 'name' => $form->model->get('from_name'), | ||
| 'email' => $form->model->get('from_email'), | ||
| ]); | ||
|
|
||
| $mlTo->saveRows(); | ||
| $mlTokens->saveRows(); | ||
| $mlCc->saveRows(); | ||
| $mlBcc->saveRows(); | ||
| $mlReplyTo->saveRows(); | ||
|
|
||
| $form->model->save(); | ||
|
|
||
| return $this->loader->jsReload(); | ||
| }); |
There was a problem hiding this comment.
Is this the correct way to manage ContainsOne/Many in Forms?
abbadon1334
force-pushed
the
update/4.0
branch
from
69fce6a to
5801633
Compare
|
Push forced to trigger deactivated GitActions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.