Skip to content

Conversation

abhinavmathur-atlan
Copy link
Collaborator

Added Health Checkpoint as requested in Discussion

changed default path from / to /mcp/

Copy link
Member

@firecast firecast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might not require fastapi, we can just leverage existing packages. Ex. https://gofastmcp.com/deployment/running-server#custom-routes

)
parser.add_argument(
"--path", type=str, default="/", help="Path of the streamable HTTP server"
"--path", type=str, default="/mcp/", help="Path of the streamable HTTP server"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also any specific reason for this change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MCP server’s endpoint is mounted at /mcp/ for Streamable HTTP transport and /sse/ for SSE transport if there is no argument
Link

, so this helps standardise things
also /health does'nt work if mcp server is also running at root

Copy link
Member

@firecast firecast Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it standardise things? /health should work no matter what the base path is

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The default for fastmcp if we dont pass the default argument as / is /mcp/
and /health doesnt work if mcp is run at root because if fastmcp server is started at / as
base path then any end point after / will go to fastmcp standard

this happens when theyre at the same path

image

When FastMCP runs at the root path (/), all HTTP requests go through the MCP protocol handler first, which requires the mcp-session-id header.

Copy link
Member

@firecast firecast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to change documentation to tell the default path change as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants