-
Notifications
You must be signed in to change notification settings - Fork 14
health checkpt added #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
health checkpt added #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might not require fastapi, we can just leverage existing packages. Ex. https://gofastmcp.com/deployment/running-server#custom-routes
) | ||
parser.add_argument( | ||
"--path", type=str, default="/", help="Path of the streamable HTTP server" | ||
"--path", type=str, default="/mcp/", help="Path of the streamable HTTP server" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also any specific reason for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MCP server’s endpoint is mounted at /mcp/ for Streamable HTTP transport and /sse/ for SSE transport if there is no argument
Link
, so this helps standardise things
also /health does'nt work if mcp server is also running at root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does it standardise things? /health
should work no matter what the base path is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

The default for fastmcp if we dont pass the default argument as / is /mcp/
and /health doesnt work if mcp is run at root because if fastmcp server is started at / as
base path then any end point after / will go to fastmcp standard
this happens when theyre at the same path

When FastMCP runs at the root path (/), all HTTP requests go through the MCP protocol handler first, which requires the mcp-session-id header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need to change documentation to tell the default path change as well?
Added Health Checkpoint as requested in Discussion
changed default path from
/
to/mcp/