feat: add more checks

atlanhq · Jun 4, 2024 · 3cd1e03 · 3cd1e03
1 parent f38a52a
commit 3cd1e03
Showing 1 changed file with 18 additions and 1 deletion.
diff --git a/repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java b/repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
@@ -2709,8 +2709,25 @@ private void repairMeanings(AtlasVertex assetVertex) {
     }
     @Override
     public void repairAlias(String guid) throws AtlasBaseException {
-        // Fetch entity with extenfo
+        // Fetch entity with extInfo
         AtlasEntity.AtlasEntityWithExtInfo entity = entityRetriever.toAtlasEntityWithExtInfo(guid);
+
+        if (entity == null) {
+            throw new AtlasBaseException(AtlasErrorCode.INSTANCE_GUID_NOT_FOUND, guid);
+        }
+
+        // Validate entity status
+        if (entity.getEntity().getStatus() != ACTIVE) {
+            throw new AtlasBaseException(AtlasErrorCode.INSTANCE_GUID_DELETED, guid);
+        }
+
+        // Validate entity type
+        String entityType = entity.getEntity().getTypeName();
+        if (!PERSONA_ENTITY_TYPE.equals(entityType)) {
+            throw new AtlasBaseException(AtlasErrorCode.INVALID_OBJECT_ID, entityType);
+        }
+
+        // Rebuild alias
         this.esAliasStore.rebuildAlias(entity);
     }
 }