[fix] optimise code

atlanhq · Aug 23, 2024 · 61c9945 · 61c9945
1 parent 3172f85
commit 61c9945
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java b/repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java
@@ -591,9 +591,9 @@ private void updateParentNodesForEachEntity(AtlasLineageListContext lineageListC
                                         for (String parentOfParent : parentsOfParentNodes) {
                                             AtlasVertex vertex = AtlasGraphUtilsV2.findByGuid(this.graph, parentOfParent);
                                             if (vertex != null) {
-                                                Map<String, String> details = fetchAttributes(vertex, FETCH_ENTITY_ATTRIBUTES);
                                                 // Check if the guid is already in the set
                                                 if (!seenGuids.contains(parentOfParent)) {
+                                                    Map<String, String> details = fetchAttributes(vertex, FETCH_ENTITY_ATTRIBUTES);
                                                     parentNodesOfParentWithDetails.add(details);
                                                     seenGuids.add(parentOfParent); // Add the guid to the set
                                                 }
@@ -626,8 +626,8 @@ private void updateParentNodesForEachEntity(AtlasLineageListContext lineageListC
                                         for (String childOfChild : childrenOfChildNode) {
                                             AtlasVertex vertex = AtlasGraphUtilsV2.findByGuid(this.graph, childOfChild);
                                             if (vertex != null) {
-                                                Map<String, String> details = fetchAttributes(vertex, FETCH_ENTITY_ATTRIBUTES);
                                                 if (!seenGuids.contains(childOfChild)) {
+                                                    Map<String, String> details = fetchAttributes(vertex, FETCH_ENTITY_ATTRIBUTES);
                                                     childrenNodesOfChildrenWithDetails.add(details);
                                                     seenGuids.add(childOfChild); // Add the guid to the set
                                                 }