Merge pull request #2843 from atlanhq/hist-bucket

fix: add few more buckets to expand our area of P99 in histogram
atlanhq · Feb 12, 2024 · e22f226 · e22f226
2 parents fef9ca3 + 6cebca9
commit e22f226
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/common/src/main/java/org/apache/atlas/service/metrics/MetricsRegistryServiceImpl.java b/common/src/main/java/org/apache/atlas/service/metrics/MetricsRegistryServiceImpl.java
@@ -68,7 +68,25 @@ public void collectIndexsearch(String requestId, String requestUri, List<AtlasPe
         try {
             for(AtlasPerfMetrics.Metric metric : applicationMetrics){
                 Timer.builder(APPLICATION_LEVEL_METRICS_SUMMARY)
-                        .publishPercentileHistogram()
+                        .serviceLevelObjectives(
+                                Duration.ofMillis(500),
+                                Duration.ofMillis(750),
+                                Duration.ofMillis(1000),
+                                Duration.ofMillis(1200),
+                                Duration.ofMillis(1500),
+                                Duration.ofSeconds(2),
+                                Duration.ofSeconds(3),
+                                Duration.ofSeconds(4),
+                                Duration.ofSeconds(5),
+                                Duration.ofSeconds(7),
+                                Duration.ofSeconds(10),
+                                Duration.ofSeconds(15),
+                                Duration.ofSeconds(20),
+                                Duration.ofSeconds(25),
+                                Duration.ofSeconds(30),
+                                Duration.ofSeconds(40),
+                                Duration.ofSeconds(60)
+                        )
                         .publishPercentiles(PERCENTILES)
                         .tags(convertToMicrometerTags(metric.getTags()))
                         .register(getMeterRegistry()).record(metric.getTotalTimeMSecs(), TimeUnit.MILLISECONDS);

diff --git a/intg/src/main/java/org/apache/atlas/model/discovery/IndexSearchParams.java b/intg/src/main/java/org/apache/atlas/model/discovery/IndexSearchParams.java
@@ -83,6 +83,7 @@ public String toString() {
                 ", persona='" + persona + '\'' +
                 ", queryString='" + queryString + '\'' +
                 ", allowDeletedRelations=" + allowDeletedRelations +
+                ", utmTags="+ getUtmTags() +
                 '}';
     }
 }