Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLT 290 : Added “uri” projection as part of method level metrics #2423

Merged
merged 3 commits into from
Oct 27, 2023
Merged

PLT 290 : Added “uri” projection as part of method level metrics #2423

merged 3 commits into from
Oct 27, 2023

Conversation

n5nk
Copy link

@n5nk n5nk commented Oct 27, 2023 •
edited
Loading

Change description

Added “uri” as one of the projections for metastore observability metrics, which are published at method level

method_dist_summary_seconds_count{integration="local",name="elasticSearchQuery",service="atlas-metastore",uri="/api/(meta|atlas/v2)/search/indexsearch",} 1.0
method_dist_summary_seconds_sum{integration="local",name="elasticSearchQuery",service="atlas-metastore",uri="/api/(meta|atlas/v2)/search/indexsearch",} 0.528

In beta COPS
Screenshot 2023-10-27 at 5 00 08 PM

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

checkaayush
checkaayush reviewed Oct 27, 2023
View reviewed changes
repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java
@@ -128,7 +128,11 @@ public Object invoke(MethodInvocation invocation) throws Throwable {
} else {
doRollback(logRollback, t);
}
throw t;
if (checkForBatchTooLargeError(t)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these changes have come from the previous PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

checkaayush
checkaayush approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@checkaayush checkaayush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n5nk n5nk merged commit 32dba8b into staging Oct 27, 2023
5 checks passed
@checkaayush checkaayush deleted the PLT-290 branch April 23, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@checkaayush checkaayush checkaayush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@n5nk @checkaayush @sumandas0 @nikhilbonte21