Update Classification add/delete behaviour #2723
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
JIRA :
https://atlanhq.atlassian.net/browse/PLT-367
Current behaviour :
Example :
If 3 tags are added to single entity
there use to be three
CLASSIFICATION_ADDED
events for that entityIf 3 tags are added to two entities
there use to be six
CLASSIFICATION_ADDED
events (3 events per entity)Desired Behaviour:
Example :
If 3 tags are added to single entity
there will be one
CLASSIFICATION_ADDED
event for that entityIf 3 tags are added to two entities
there will be two
CLASSIFICATION_ADDED
event (1 event per entity)Area of Impact :
Proposed changes to embed desired behaviour :
Classification_added
Current behaviour
i. We have
detail
object that contains tag information.Proposed behaviour
Representing Future classification_added event
i.
detail
object will be empty.ii. add key
classificationsDetails
object to show current tagsremoved from entity.
Representing Past data classification_added event
i.
detail
object contains tag information.ii.
classificationsDetails
object will be emptyClassification_deleted
eventCurrent behaviour :
i. We have
detail
object that contains tagtypeName
only.Proposed behaviour
i.
detail
object will be empty.ii. add key
classificationsDetails
object to show current tagsremoved from entity.
i.
detail
object contains tag information.ii.
classificationsDetails
object will be empty.Type of change
Related issues
Checklists
Development
Security
Code review