feat: Policy Cache mechanism improvements[staging] #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g users efficiently""
…g users efficiently""
sumandas0
requested review from
checkaayush,
mehtaanshul,
nikhilbonte21,
n5nk and
aarshi0301
sumandas0
changed the title
n5nk
reviewed
Jan 10, 2024
| public List<UserRepresentation> getUsersMappings(int start, int size) throws AtlasBaseException { | ||
| String[] columns = {"roles", "groups"}; | ||
| List<HeraclesUserViewRepresentation> views = HERACLES.getUsersMappings(start, size, HeraclesUserViewRepresentation.sortBy, columns).body(); | ||
| List<UserRepresentation> userRepresentations = views.stream().map(x -> { |
There was a problem hiding this comment.
nit: No need for assignment userRepresentations, just return
| protected List<String> roles; | ||
| protected List<String> groups; | ||
|
|
||
| public static String sortBy = "username"; |
There was a problem hiding this comment.
I dont see a usage for this variable sortBy
There was a problem hiding this comment.
| protected List<String> roles; | ||
| protected List<String> groups; | ||
|
|
||
| public static String sortBy = "name"; |
There was a problem hiding this comment.
I dont see a usage for this variable sortBy, and its referring to name , missed deleting ?
There was a problem hiding this comment.
There was a problem hiding this comment.
rename to something like SORT_KEY_BY_NAME..
| @@ -100,6 +100,11 @@ Config getProdConfig() throws AtlasException { | |||
| .setClientName(ATLAS_METASTORE_SERVICE) | |||
| .setReadMode(ReadMode.MASTER_SLAVE) | |||
| .setCheckSentinelsList(false) | |||
| .setKeepAlive(true) | |||
There was a problem hiding this comment.
refresh the branch with master, i see unrelated commits like these
nikhilbonte21
approved these changes
Jan 10, 2024
| protected List<String> roles; | ||
| protected List<String> groups; | ||
|
|
||
| public static String sortBy = "name"; |
There was a problem hiding this comment.
rename to something like SORT_KEY_BY_NAME..
| @@ -108,7 +108,8 @@ public enum AtlasConfiguration { | |||
|
|
|||
| PERSONA_POLICY_ASSET_MAX_LIMIT("atlas.persona.policy.asset.maxlimit", 1000), | |||
| ENABLE_KEYCLOAK_TOKEN_INTROSPECTION("atlas.canary.keycloak.token-introspection", false), | |||
| KEYCLOAK_ADMIN_CLIENT_PAGINATION_SIZE("atlas.keycloak.admin.resource-pagination-size", 1500); | |||
| HERACLES_CLIENT_PAGINATION_SIZE("atlas.heracles.admin.resource-pagination-size", 100), | |||
| HERACLES_API_SERVER_URL("atlas.heracles.api.server.url", "http://heracles-service.heracles.svc.cluster.local"); | |||
There was a problem hiding this comment.
rename to atlas.heracles.api.service.url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Policy Cache mechanism improvements
More details: https://www.notion.so/atlanhq/Policy-Cache-mechanism-improvements-028fe879ed2a4604ae880a263726b2fe?pvs=4
JIRA: https://atlanhq.atlassian.net/browse/PLT-524
Test Cases: https://atlanhq.atlassian.net/browse/PLT-524?focusedCommentId=50549
Type of change
Development
Security
Code review