Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLT-573 | Add removeSupport in bulk API #2744

Merged
merged 2 commits into from
Jan 17, 2024
Merged

PLT-573 | Add removeSupport in bulk API #2744

merged 2 commits into from
Jan 17, 2024

Conversation

aarshi0301
Copy link

@aarshi0301 aarshi0301 commented Jan 10, 2024 •
edited
Loading

Change description

Developer Notes : https://www.notion.so/atlanhq/Add-append-and-remove-support-for-bulk-endpoint-0133b5b48d684a94aa350d70ba72c491

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@aarshi0301 aarshi0301 changed the title Feat/remove relationship attribute PLT-573 | Add removeSupport in bulk API Jan 10, 2024
@aarshi0301 aarshi0301 marked this pull request as draft January 10, 2024 13:30
@aarshi0301 aarshi0301 self-assigned this Jan 10, 2024
@aarshi0301 aarshi0301 marked this pull request as ready for review January 16, 2024 06:50
checkaayush
checkaayush approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@checkaayush checkaayush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. Left a minor clarification comment. Let's get 1 more approval before merge.

n5nk
n5nk suggested changes Jan 16, 2024
View reviewed changes
Copy link

@n5nk n5nk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check

  • if we need to document the change , since we have priorities set for append and remove , the way API behaves.
  • Error handling during remove , if relationship is not present.
  • Also please squash all the commits to one commit

@aarshi0301
Whitelist appendRelationshipAttribute and removeRelationshipAttribute
acbfee6 
validate if attrName exists in appendRelationshipAttribute

Evaluate attrName in appendRelationshipAttribute

add util for appendRelationshipattribute

util for processing appendRelationship attribute

add utils for appendRelationshipAttribute

add if condition to process appendRelationshipAttribute

set appendRelationshipAttribute in context

add condition to process appendRelationshipAttribute

Add appendRelationshipAttribute util in EntityMutationContexr

add flag to validate if appendRelationshipAttributes are visited

Set flag if appendRelationshipAttribute is ever visited

Set appendRelationshipAttribute

Remove comments

Add utils for removeRelationshipAttributes

processRemoveRelationAttributes

set removeRelationshipAttributes in context

Add utils to process removeRelationshipAttributes and minor code refactoring

code cleanup

consume removeRelationshipAttributes

add util to consumeRemoveRelationshipAttributes

Update removeRelationshipAttribute util

Expose method to fetch relationship
@aarshi0301
Add bulk and remove attribute support in bulk API
71dbaeb
@aarshi0301 aarshi0301 force-pushed the feat/removeRelationshipAttribute branch from 64125b1 to 71dbaeb Compare January 17, 2024 14:23
@aarshi0301
Copy link
Author

Please check

  • if we need to document the change , since we have priorities set for append and remove , the way API behaves.
  • Error handling during remove , if relationship is not present.
  • Also please squash all the commits to one commit

Squashed commits

aarshi0301
aarshi0301 commented Jan 17, 2024
View reviewed changes
Copy link
Author

@aarshi0301 aarshi0301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@aarshi0301 aarshi0301 merged commit 7194492 into master Jan 17, 2024
4 checks passed
@checkaayush checkaayush deleted the feat/removeRelationshipAttribute branch April 23, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n5nk n5nk n5nk approved these changes

@checkaayush checkaayush checkaayush approved these changes

@mehtaanshul mehtaanshul Awaiting requested review from mehtaanshul

@sumandas0 sumandas0 Awaiting requested review from sumandas0

@nikhilbonte21 nikhilbonte21 Awaiting requested review from nikhilbonte21

Assignees

@aarshi0301 aarshi0301

Labels
DO NOT MERGE master READY FOR REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aarshi0301 @checkaayush @n5nk