Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add error code for unknown errors so we could run pinpoint on them #2803

Merged
merged 4 commits into from
Jan 31, 2024
Merged

fix: Add error code for unknown errors so we could run pinpoint on them #2803

merged 4 commits into from
Jan 31, 2024

Conversation

sumandas0
Copy link

Add special error code to select WF failure handler as PinPoint

We retry some failures but do not run the pinpoint handler in cases of handled errors, or when the error code is greater than 500. Therefore, if an error is thrown intentionally, we will select the failure handler PINPOINT, which is UNKNOWN_SERVER_ERROR.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

@sumandas0 sumandas0 self-assigned this Jan 31, 2024
@sumandas0 sumandas0 merged commit 8a876e6 into master Jan 31, 2024
8 checks passed
@sumandas0 sumandas0 deleted the error-code-fix branch January 31, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarshi0301 aarshi0301 aarshi0301 approved these changes

@checkaayush checkaayush checkaayush approved these changes

@mehtaanshul mehtaanshul Awaiting requested review from mehtaanshul

Assignees

@sumandas0 sumandas0

Labels
READY FOR REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumandas0 @checkaayush @aarshi0301