Pre Processors for Domain Move #2876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRATHAM2002-DS
requested review from
akashdeep01,
mehtaanshul and
nikhilbonte21
...apache/atlas/repository/store/graph/v2/preprocessor/datamesh/AbstractDomainPreProcessor.java
Show resolved
Hide resolved
...rg/apache/atlas/repository/store/graph/v2/preprocessor/datamesh/DataProductPreProcessor.java
Outdated
Show resolved
Hide resolved
...rg/apache/atlas/repository/store/graph/v2/preprocessor/datamesh/DataProductPreProcessor.java
Outdated
Show resolved
Hide resolved
...rg/apache/atlas/repository/store/graph/v2/preprocessor/datamesh/DataProductPreProcessor.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/atlas/repository/store/graph/v2/preprocessor/datamesh/DomainPreProcessor.java
Show resolved
Hide resolved
nikhilbonte21
approved these changes
Mar 13, 2024
| @@ -32,6 +32,12 @@ public class PreProcessorUtils { | |||
| public static final String GLOSSARY_TERM_REL_TYPE = "AtlasGlossaryTermAnchor"; | |||
| public static final String GLOSSARY_CATEGORY_REL_TYPE = "AtlasGlossaryCategoryAnchor"; | |||
|
|
|||
| //DataMesh models constants | |||
| public static final String DATA_PRODUCT_TYPE = "DataProduct"; | |||
There was a problem hiding this comment.
I think DATA_PRODUCT_TYPE from common/src/main/java/org/apache/atlas/repository/Constants.java can be reused
| import static org.apache.atlas.repository.util.AtlasEntityUtils.mapOf; | ||
|
|
||
| public class DataProductPreProcessor extends AbstractDomainPreProcessor { | ||
| private static final Logger LOG = LoggerFactory.getLogger(DomainPreProcessor.class); |
| public void processAttributes(AtlasStruct entityStruct, EntityMutationContext context, | ||
| EntityMutations.EntityOperation operation) throws AtlasBaseException { | ||
| //Handle name & qualifiedName | ||
| if (operation == EntityMutations.EntityOperation.UPDATE && LOG.isDebugEnabled()) { |
There was a problem hiding this comment.
remove EntityOperation.UPDATE condition
| } | ||
|
|
||
|
|
||
| AtlasEntity entity = (AtlasEntity) entityStruct; |
There was a problem hiding this comment.
wrap these statements as well inside if (operation == EntityMutations.EntityOperation.UPDATE)
these will no be called when not required
| setParent(entity, context); | ||
|
|
||
| if (operation == EntityMutations.EntityOperation.UPDATE) { | ||
| processUpdateDomain(entity, vertex); |
There was a problem hiding this comment.
processUpdateDomain -> processUpdateProduct
| String currentDomainQualifiedName = (String) currentDomainHeader.getAttribute(QUALIFIED_NAME); | ||
|
|
||
| String newDomainQualifiedName = (String) parentDomain.getAttribute(QUALIFIED_NAME); | ||
| String superDomainQualifiedName = (String) parentDomain.getAttribute(SUPER_DOMAIN_QN); |
There was a problem hiding this comment.
superDomainQualifiedName -> newSuperDomainQualifiedName
| isAuthorized(currentDomainHeader, parentDomain); | ||
|
|
||
| processMoveDataProductToAnotherDomain(entity, currentDomainQualifiedName, newDomainQualifiedName, vertexQnName, superDomainQualifiedName); | ||
| entity.setAttribute(PARENT_DOMAIN_QN, newDomainQualifiedName); |
| boolean exists = false; | ||
| try { | ||
| List mustClauseList = new ArrayList(); | ||
| mustClauseList.add(mapOf("term", mapOf("__typeName.keyword", DATA_DOMAIN_ENTITY_TYPE))); |
There was a problem hiding this comment.
DATA_DOMAIN_ENTITY_TYPE -> I think it should be DATA_PRODUCT_ENTITY_TYPE
| public void processAttributes(AtlasStruct entityStruct, EntityMutationContext context, | ||
| EntityMutations.EntityOperation operation) throws AtlasBaseException { | ||
| //Handle name & qualifiedName | ||
| if (operation == EntityMutations.EntityOperation.UPDATE && LOG.isDebugEnabled()) { |
There was a problem hiding this comment.
operation == EntityMutations.EntityOperation.UPDATE -> not needed
| entityStruct.getAttribute(QUALIFIED_NAME), operation); | ||
| } | ||
|
|
||
| this.context = context; |
There was a problem hiding this comment.
enclose this within if (operation == EntityMutations.EntityOperation.UPDATE) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Type of change
Related issues
Checklists
Development
Security
Code review