Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

atlanhq / atlas-metastore Public

forked from apache/atlas

Notifications You must be signed in to change notification settings
Fork 10
Star 4

Code
Pull requests 46
Actions
Projects
Security
Insights

Additional navigation options

Code
Pull requests
Actions
Projects
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DQ-22: Data contract PreProcessor #2937

Merged

bichitra95 merged 25 commits into master from data-contract

Apr 30, 2024

Merged

DQ-22: Data contract PreProcessor #2937

bichitra95 merged 25 commits into master from data-contract

Apr 30, 2024

Conversation 72 Commits 25 Checks 4 Files changed

Conversation

Copy link

bichitra95 commented Apr 22, 2024 •

edited

Loading

Change description

This Code change will handle the creation and updation of DataContract typedef.

Type of change

Bug fix (fixes an issue)
New feature (adds functionality)

Related issues

Feature #1

Checklists

Development

Lint rules pass locally
Application changes have been tested thoroughly
Automated tests covering modified code pass

Security

Security impact of change has been considered
Code follows company security practices and guidelines

Code review

Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
"Ready for review" label attached and reviewers assigned
Changes have been reviewed by at least one other contributor
Pull request linked to task tracker where applicable

Sorry, something went wrong.

All reactions

bichitra95 added 14 commits

March 28, 2024 10:02


          Add DataContract preprocessor and versioning

27285ad


          Refactore contract code and release

5c53ca1


          Add unknown attributes to DataContract and fix minor bugs

94d98db


          Add attribute hasContract for assets

d64e969


          Add validation of data contract spec

6ee00aa


          Fix audit logs for associated asset

c79dfa0


          Update dataset spec structure

723286a


          Minor bug fix

3e6f1b2


          Refactor with new attributes

f69d6f6


          Fix order of attributes in contract and change dataContractVersion to…

3e75d0f

… integer


          Add bootstrap policy for DataContract CRU

2e30f63


          Fix qualifiedName of the contract

32104e9


          Add asset guid in DataContract asset and minor fixes

8185bfe


          Inconsistency in relationship fixed for data contract<>asset

e863c13

bichitra95 changed the title ~~Data contract PreProcessor~~ DG-22: Data contract PreProcessor


          Removed maven release for data-contract branch

checkaayush requested review from sumandas0 and mehtaanshul

April 25, 2024 05:54


          Change datasource to data_source in DataContract

4cd524d

nikhilbonte21 requested changes

View reviewed changes

addons/policies/bootstrap_entity_policies.json Outdated Show resolved Hide resolved

...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java Outdated Show resolved Hide resolved

...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java Outdated Show resolved Hide resolved

...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java Outdated Show resolved Hide resolved

...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java Outdated Show resolved Hide resolved

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractVersionUtils.java Outdated Show resolved Hide resolved

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractVersionUtils.java Outdated Show resolved Hide resolved

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractVersionUtils.java Outdated Show resolved Hide resolved

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractVersionUtils.java Outdated Show resolved Hide resolved

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved

nikhilbonte21 changed the title ~~DG-22: Data contract PreProcessor~~ DQ-22: Data contract PreProcessor

bichitra95 added 4 commits

April 27, 2024 15:16


          Merge create and update AuthPolicy for DataContract

8ed00b3


          Update DataContract attributes from public to private and create gett…

…er for needed attributes


          Add setter for private attributes and formatted the file

09c500a


          Address PR review changes

d78cdc1

* Remove version util and moved getCurrentVersion method to preprocessor
* Remove unused varibles
* Optimize fetching latest version of contract
*

nikhilbonte21 requested changes

View reviewed changes

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Show resolved Hide resolved

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Show resolved Hide resolved

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved

nikhilbonte21 requested changes

View reviewed changes

...ache/atlas/repository/store/graph/v2/preprocessor/contract/AbstractContractPreProcessor.java Outdated Show resolved Hide resolved

...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java Show resolved Hide resolved

...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java Outdated Show resolved Hide resolved

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Show resolved Hide resolved

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Show resolved Hide resolved


          Address code review comments

9779ffe

    * Remove purgebyId call and remove skip auth in the purge method
    * Make DataContract attributes public for serialisation and deserialisation of JSON
    * Make minor changes for optimisation

nikhilbonte21 requested changes

View reviewed changes

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved

...main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/DataContract.java Show resolved Hide resolved

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Show resolved Hide resolved

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated Show resolved Hide resolved


          Remove redundant code/arguments in contract preprocessor

191b447

bichitra95 added 2 commits

April 30, 2024 12:12


          Add remove user added relationship to control relationship update

9f26e46


          Ignoring null value fields

418a8cf

bichitra95 commented

View reviewed changes

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Show resolved Hide resolved

bichitra95 commented

View reviewed changes

...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Show resolved Hide resolved

nikhilbonte21 previously approved these changes

View reviewed changes

sumandas0 reviewed

View reviewed changes

repository/pom.xml Outdated

+                      <dependency>
+                          <groupId>org.hibernate</groupId>
+                          <artifactId>hibernate-validator</artifactId>
+                          <version>4.3.0.Final</version>

Copy link

sumandas0 Apr 30, 2024

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a CVE of severity medium here! please fix it. Can't let it to be a backlog

https://github.com/atlanhq/atlas-metastore/actions/runs/8890490131

Check how difficult it is to fix it.

Sorry, something went wrong.

All reactions

Copy link

sumandas0 Apr 30, 2024

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically dependency review is failing

Sorry, something went wrong.

All reactions

Copy link

sumandas0 Apr 30, 2024

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just bump it to 4.3.2 and we will be fine here

Sorry, something went wrong.

All reactions

Copy link

sumandas0 Apr 30, 2024

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GHSA-845h-985r-jrqh

Sorry, something went wrong.

All reactions

Copy link

Author

bichitra95 Apr 30, 2024

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially, I tried with the latest version for Java 8 supported https://central.sonatype.com/artifact/org.hibernate.validator/hibernate-validator/6.2.5.Final

This is not working as the repository/gorupId got changed from org.hibernate to org.hibernate.validator which is why the validator is not working (possible issue might be due to conflict in dependency).

I have limited knowledge of how dependency works in Java. If you can help debug further, I am happy to jump on an call and solve this.

Sorry, something went wrong.

All reactions


          Upgrade validator version to avoid vulnerability

fb0ee62

bichitra95 dismissed nikhilbonte21’s stale review via

fb0ee62

April 30, 2024 12:33

sumandas0 approved these changes

View reviewed changes

bichitra95 merged commit 7a3a1c5 into master

4 checks passed

bichitra95 deleted the data-contract branch

April 30, 2024 13:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sumandas0 sumandas0 approved these changes

nikhilbonte21 nikhilbonte21 left review comments

mehtaanshul Awaiting requested review from mehtaanshul

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.