Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Added support for "search_after" in elasticsearch queries #3230

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

hitk6
Copy link
Collaborator

@hitk6 hitk6 commented Jun 10, 2024

Change description

Description here

  • In searchMetadata field adding the sort field from elasticsearch response with same datatypes.
  • This will help implement search_after pagination usecase in indexsearch queries.
  • Earlier we used to use from pagination which is not performant when we want to paginate over large number of documents. doc

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@hitk6 hitk6 changed the title Plt 1651 search after feature: Added support for "search_after" in elasticsearch queries Jun 11, 2024
@hitk6 hitk6 requested a review from sumandas0 June 11, 2024 04:50
@sumandas0 sumandas0 changed the base branch from staging to maintenancemode June 11, 2024 04:57
@sumandas0 sumandas0 changed the base branch from maintenancemode to staging June 11, 2024 04:57
@hitk6 hitk6 merged commit 33b0903 into staging Jun 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant