Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DG-1442 Fixed a minor bug where an empty lexo attribute in update call was removed from vertex #3249

Merged
merged 14 commits into from
Jun 14, 2024
Merged

DG-1442 Fixed a minor bug where an empty lexo attribute in update call was removed from vertex #3249

merged 14 commits into from
Jun 14, 2024

Conversation

hr2904
Copy link
Collaborator

@hr2904 hr2904 commented Jun 14, 2024

Change description

Fixed a minor bug where an empty lexo attribute in update call was removed from vertex

Type of change

  • Bug fix (fixes an issue)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

hr2904 added 14 commits June 14, 2024 13:19
@hr2904
Init commmit, added lexorank generation util lib and logic for append…
cd985f6 
…ing the lexo attribute to category.
@hr2904
Added method to append lexicographicSortOrder attribute to any Glossa…
0bdee87 
…ry based Entity that does not have it while creation.
@hr2904
Added LexoRank Validation method, with tentative rebalancing trigger …
360b225 
…logic
@hr2904
Corrected a method rename
6a55f13
@hr2904
Added a check in validateLexoRank which checks if another entity with…
0de8f95 
… duplicate lexorank doesnt exist in scenario where lexorank is being sent from user.
@hr2904
Added a check , such that if bulk request is from migration, it will …
76dbc23 
…override the check for for duplicate lexorank.
@hr2904
Modified ES query.
5a4f235
@hr2904
Modified an edge statement such that, when a new lexorank for cat is …
d8858f0 
…generated, it is not a duplicate of a term in same linear data set
@hr2904
Reverted the check, instead added padded new offset for terms.
41622bf
@hr2904
fixed the caching logic, by adding the bifurcation for terms and cate…
7b6a4ab 
…gories
@hr2904
Fixed PR comments
8c7b50d
@hr2904
Added caching for same ranks in same request, for prevention of dupli…
c7d6791 
…cacy.
@hr2904
Fixed a minor bug where an empty lexo attribute in update call was re…
de75af0 
…moving the attribute from the vertex.
@hr2904
Merge branch 'DG-1442_2' into beta-1442-helper
c9857c5 
# Conflicts:
#	repository/src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/PreProcessorUtils.java
#	repository/src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/glossary/CategoryPreProcessor.java
#	repository/src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/glossary/GlossaryPreProcessor.java
#	repository/src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/glossary/TermPreProcessor.java
@hr2904 hr2904 merged commit f8fed06 into beta Jun 14, 2024
3 checks passed
@hr2904 hr2904 mentioned this pull request Jun 14, 2024
Merged
@hr2904 hr2904 deleted the beta-1442-helper branch June 19, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hr2904