Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG-1530 Changing the wildcard pattern for indexsearch to be more efficient #3260

Merged
merged 31 commits into from
Jul 11, 2024

Conversation

hr2904
Copy link
Collaborator

@hr2904 hr2904 commented Jun 17, 2024

Change description

Whenever creating/updating a policy, if policyResources contains an all domains pattern, these steps would happen:

  • Convert this old pattern to new pattern i.e default/domain/*super
  • Remove any specific domain access to be removed, i.e If the resources have a. All Domains b. Some Domain QN, -> that specific domain will be taken out of the list, as its redundant.

Changing the domain wildcard alias also fixed a bug where , old pattern was getting stakeholder entities as well as domain entities, where we are only supposed to get domain entities.

Type of change

  • Bug fix (fixes an issue)

Related issues

Fix #1
TestCases considered and tested on here

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

hr2904 added 2 commits July 1, 2024 20:25
…e logic such that policies,stakeholder, stakeholderTitle will write new wildcard pattern.
@hr2904 hr2904 merged commit 39144b8 into staging Jul 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants