forked from apache/atlas
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DG-1442 Modification of the PreProcessor for Custom Sort - Bulk Update Edge Cases #3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhilbonte21
requested changes
Jun 20, 2024
...src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/PreProcessorUtils.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/PreProcessorUtils.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/PreProcessorUtils.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/PreProcessorUtils.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/PreProcessorUtils.java
Outdated
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/glossary/CategoryPreProcessor.java
Outdated
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/glossary/GlossaryPreProcessor.java
Outdated
Show resolved
Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/glossary/GlossaryPreProcessor.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/atlas/repository/store/graph/v2/preprocessor/glossary/TermPreProcessor.java
Outdated
Show resolved
Hide resolved
nikhilbonte21
requested changes
Jun 25, 2024
...src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/PreProcessorUtils.java
Show resolved
Hide resolved
nikhilbonte21
previously approved these changes
Jun 26, 2024
mehtaanshul
previously approved these changes
Jun 28, 2024
mehtaanshul
reviewed
Jun 28, 2024
...src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/PreProcessorUtils.java
Outdated
Show resolved
Hide resolved
mehtaanshul
previously approved these changes
Jun 28, 2024
nikhilbonte21
previously approved these changes
Jun 28, 2024
Changes look good to me, I will do a quick testing tomorrow on datamesh.atlan.com before approving |
…ing the lexo attribute to category.
…ry based Entity that does not have it while creation.
… duplicate lexorank doesnt exist in scenario where lexorank is being sent from user.
…override the check for for duplicate lexorank.
…generated, it is not a duplicate of a term in same linear data set
…moving the attribute from the vertex.
nikhilbonte21
requested changes
Oct 8, 2024
...src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/PreProcessorUtils.java
Outdated
Show resolved
Hide resolved
mehtaanshul
approved these changes
Oct 15, 2024
nikhilbonte21
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Type of change
Related Docs
Checklists
Development
Security
Code review