Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dg 1637 Empty Filter for Persona without any policy #3287

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

PRATHAM2002-DS
Copy link

Change description

Preconditions:

  • Create a Persona, add yourself in to users list.
  • Do not create any policy or,
  • Any existing persona that do not have any policy due to either never added any policy or deleted all existing policies

Steps:

  • Go to Assets page, select Persona
  • Go to Assets page, select Persona, go to Glossary page

Actual Result:

  • On both Assets & Glossary page, no asset should be visible

Expected Result:

  • All assets or GCTs are listed

Root Cause:

  • When we create a Persona, we create ES alias without filters
  • When deleted any policy in Persona, we simply reform ES alias filters & overrride

Solution:

  • When creating a new Persona, we should create ES alias with filter in such a way that it does not return anything
  • When deleting a policy, check if filters is empty, if yes add filter that it does not return anything
  • We have simply used match_none for empty filters.

Jira Link:

https://atlanhq.atlassian.net/browse/DG-1637

Test-Case Doc

https://www.notion.so/atlanhq/Test-Case-Doc-For-DG-1637-7853efb87dca437992b9288c59d93568

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@nikhilbonte21 nikhilbonte21 merged commit 7dc8c7a into staging Jun 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants