Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DG-1682 - Fix: Ignore classification option validation when propogate is false #3311

Merged
merged 2 commits into from
Jul 16, 2024
Merged

DG-1682 - Fix: Ignore classification option validation when propogate is false #3311

merged 2 commits into from
Jul 16, 2024

Conversation

krsoninikhil
Copy link

@krsoninikhil krsoninikhil commented Jul 5, 2024 •
edited
Loading

Change description

If propogate option is false then restrict option are ingored and only checked if propogate if true

Edit: More test cases added here -- https://www.notion.so/atlanhq/setClassification-Update-throwing-validation-error-e187bc4a7bfe447099b6e26d1c150e3b

  • Case: Input -- restrict options being true while propagate is false, result -- successful
image
  • Case: Input -- restrict options being true while propagate is false, result for update which was failing earlier -- successful
image
  • Case: Input -- restrict options being true while propagate is true, result -- error (as expected)
image

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #DG-1682

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@krsoninikhil
fix: Ignore classification option validation when propogate is false
bc5e933 
If propogate option is false then restrict option are ingored
and only checked if propogate if true
@krsoninikhil
Use previous values for missing restrict option
e31e6b9 
If a restrict via lineage or restrict via hierarchy option is
missing while updating the set classification, this will use
the previously saved value. This is done to avoid bypassing
the validation if setting the options one by one.
@krsoninikhil krsoninikhil force-pushed the ns/fix/DG-1682-propogate-classification branch from f6bcdea to e31e6b9 Compare July 10, 2024 11:04
@krsoninikhil krsoninikhil changed the title fix: Ignore classification option validation when propogate is false DG-1682 - Fix: Ignore classification option validation when propogate is false Jul 11, 2024
@krsoninikhil krsoninikhil merged commit ee17588 into master Jul 16, 2024
9 of 18 checks passed
@sumandas0 sumandas0 deleted the ns/fix/DG-1682-propogate-classification branch February 25, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourikghosh sourikghosh sourikghosh approved these changes

@nikhilbonte21 nikhilbonte21 nikhilbonte21 approved these changes

@hr2904 hr2904 hr2904 approved these changes

Assignees
No one assigned
Labels
READY FOR REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krsoninikhil @sourikghosh @nikhilbonte21 @hr2904