Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG-1682 - Use previous values for missing restrict option #3331

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

krsoninikhil
Copy link

@krsoninikhil krsoninikhil commented Jul 11, 2024

If a restrict via lineage or restrict via hierarchy option is missing while updating the set classification, this will use the previously saved value. This is done to avoid bypassing the validation if setting the options one by one.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

If a restrict via lineage or restrict via hierarchy option is
missing while updating the set classification, this will use
the previously saved value. This is done to avoid bypassing
the validation if setting the options one by one.
@krsoninikhil krsoninikhil changed the title Use previous values for missing restrict option DG-1682: Use previous values for missing restrict option Jul 11, 2024
@krsoninikhil krsoninikhil changed the title DG-1682: Use previous values for missing restrict option DG-1682 - Use previous values for missing restrict option Jul 11, 2024
@krsoninikhil krsoninikhil merged commit 6707730 into beta Jul 11, 2024
9 of 18 checks passed
@sumandas0 sumandas0 deleted the ns/fix/DG-1682-propogate-classification branch February 25, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant