Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DQ-302 Contract version 2.0 #3346

Merged
merged 2 commits into from
Jul 24, 2024
Merged

DQ-302 Contract version 2.0 #3346

merged 2 commits into from
Jul 24, 2024

Conversation

bichitra95
Copy link

@bichitra95 bichitra95 commented Jul 19, 2024 •
edited
Loading

Change description

This enhancement will change the behaviour of how the contract versioning is created. Now new version will not be created for every change to the contract, instead, it will keep on updating the same draft version and will create a new version incase the current version is published.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix DQ-302

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

nikhilbonte21
nikhilbonte21 requested changes Jul 19, 2024
View reviewed changes
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/contract/ContractPreProcessor.java Outdated
"x-atlan-request-id", "").contains("json-to-yaml-migration");
if (!requestFromMigration && !StringUtils.isEmpty(contractString) &&
!contract.equals(DataContract.deserialize(existingContractString))) {
if (entity.getAttribute(ATTR_CERTIFICATE_STATUS) == DataContract.Status.VERIFIED.name() ||
Copy link

@nikhilbonte21 nikhilbonte21 Jul 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this check done on entity as well?

@bichitra95 bichitra95 requested a review from sumandas0 July 23, 2024 05:35
@bichitra95 bichitra95 merged commit 649cb0f into master Jul 24, 2024
5 checks passed
@bichitra95 bichitra95 deleted the DQ-302-contract-versioning-2-0 branch July 24, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumandas0 sumandas0 sumandas0 approved these changes

@nikhilbonte21 nikhilbonte21 nikhilbonte21 approved these changes

Assignees
No one assigned
Labels
READY FOR REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bichitra95 @sumandas0 @nikhilbonte21