New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DG-1697: Adding endpoint for linking/unlink policy #3349

Merged

arpit-at merged 25 commits into master from policyendpointsmasterss

Aug 5, 2024

arpit-at commented Jul 19, 2024

Change description

Created two new endpoints in the metastore:

Unlink Policies

Endpoint: POST alternate/{policy-id}/unlink-business-policy
Body: {"unlinkGuids":["assetId1", "assetId2"]}

2 Link Policies

Endpoint: POST alternate/{policy-id}/link-business-policy
Body: {"linkGuids":["assetId1", "assetId2"]}

These endpoints link or unlink policies from a set of asset IDs with minimal operations:

Verify if the request is from a service account.
Loop through all assets.
Load each asset.
Link or unlink the policy.
Increment or decrement the asset policies count.

Type of change

Bug fix (fixes an issue)
New feature (adds functionality)

Related issues

Checklists

Development

Lint rules pass locally
Application changes have been tested thoroughly
Automated tests covering modified code pass

Security

Security impact of change has been considered
Code follows company security practices and guidelines

Code review

[ x] Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
"Ready for review" label attached and reviewers assigned
Changes have been reviewed by at least one other contributor
Pull request linked to task tracker where applicable

arpit-at added 5 commits

July 3, 2024 20:01


          DG-1697: Adding endpoint for linking/unlink policy

8936e59


          DG-1697: Added linking and unlinking api for business-policy

72b591b


          DG-1697: Added linking and unlinking logic

815b407


          Merge branch 'policyendpointsmaster2' into policyendpointsmasters3

0616e40


          DG-1697: adding for build

5fb0aaf

arpit-at changed the title ~~Policyendpointsmasterss~~ DG-1697: Adding endpoint for linking/unlink policy

arpit-at marked this pull request as draft

July 19, 2024 10:43


          DG-1697: clean up

89f0deb

nikhilbonte21 requested changes

View reviewed changes

webapp/src/main/java/org/apache/atlas/web/rest/AlternateREST.java Outdated Show resolved Hide resolved

webapp/src/main/java/org/apache/atlas/web/rest/AlternateREST.java Outdated Show resolved Hide resolved

webapp/src/main/java/org/apache/atlas/web/rest/AlternateREST.java Outdated Show resolved Hide resolved

intg/src/main/java/org/apache/atlas/model/instance/LinkBusinessPolicyRequest.java Outdated Show resolved Hide resolved

repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Outdated Show resolved Hide resolved

repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Outdated Show resolved Hide resolved

repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Outdated Show resolved Hide resolved

repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Show resolved Hide resolved

repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Outdated Show resolved Hide resolved

repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Outdated Show resolved Hide resolved

nikhilbonte21 requested changes

View reviewed changes

repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Outdated Show resolved Hide resolved

nikhilbonte21 requested changes

View reviewed changes

server-api/src/main/java/org/apache/atlas/RequestContext.java Outdated Show resolved Hide resolved

webapp/src/main/java/org/apache/atlas/notification/EntityNotificationSender.java Outdated Show resolved Hide resolved

sumandas0 reviewed

View reviewed changes

repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Outdated

+                      EntityMutationResponse entityMutationResponse = new EntityMutationResponse();
+                      for (AtlasVertex vertex : vertices) {
+                          // Convert each vertex to an AtlasEntityHeader and add it to the response
+                          AtlasEntityHeader entityHeader = entityRetriever.toAtlasEntityHeader(vertex);

sumandas0 Jul 23, 2024

Do we need to fetch entire entity and attched tags, meanings all the time , if not optimize the call to fetch only the entity header

Author

arpit-at Jul 23, 2024 •

edited

Loading

Do you mean findByGuid can be avoided?

sumandas0 reviewed

View reviewed changes

repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Outdated Show resolved Hide resolved

sumandas0 reviewed

View reviewed changes

repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Outdated Show resolved Hide resolved

sumandas0 reviewed

View reviewed changes

repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Outdated Show resolved Hide resolved

sumandas0 reviewed

View reviewed changes

repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Outdated Show resolved Hide resolved

sumandas0 reviewed

View reviewed changes

sumandas0 left a comment

Added few comments

arpit-at added 8 commits

July 24, 2024 14:13


          DG-1697: PR comments resolved

36b8f10


          DG-1697: PR comments resolved

09e7e3d


          DG-1697: PR comments resolved

4a3c887


          DG-1697: PR comments resolved

4cb6cc7


          DG-1697: PR comments resolved

c9b0274


          DG-1697: PR comments resolved

bd3fcc8


          DG-1697: PR comments resolved

a5e7103


          DG-1697: PR comments resolved

2869c0b

arpit-at marked this pull request as ready for review

July 24, 2024 13:33

arpit-at requested a review from nikhilbonte21

July 24, 2024 13:34

arpit-at added 3 commits

July 24, 2024 20:40


          DG-1697: PR comments resolved


          DG-1697: PR comments resolved

ca87c6a


          DG-1697: PR comments resolved

e8b73a5

nikhilbonte21 requested changes

View reviewed changes

...ory/src/main/java/org/apache/atlas/repository/store/graph/v2/BusinessPolicyNotifierImpl.java Outdated Show resolved Hide resolved

...ory/src/main/java/org/apache/atlas/repository/store/graph/v2/BusinessPolicyNotifierImpl.java Outdated Show resolved Hide resolved

repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Outdated Show resolved Hide resolved

...ory/src/main/java/org/apache/atlas/repository/store/graph/v2/BusinessPolicyNotifierImpl.java Show resolved Hide resolved

...ory/src/main/java/org/apache/atlas/repository/store/graph/v2/BusinessPolicyNotifierImpl.java Outdated Show resolved Hide resolved

.../src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasAlternateChangeNotifier.java Outdated Show resolved Hide resolved

.../src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasAlternateChangeNotifier.java Outdated Show resolved Hide resolved

webapp/src/main/java/org/apache/atlas/web/rest/BusinessPolicyREST.java Outdated Show resolved Hide resolved

webapp/src/main/java/org/apache/atlas/web/rest/BusinessPolicyREST.java Outdated Show resolved Hide resolved

arpit-at added 2 commits

July 25, 2024 16:28


          DG-1697: review fix

2cc48af


          DG-1697: remove unnecesary files

93e2c13

nikhilbonte21 previously approved these changes

View reviewed changes

arpit-at added 2 commits

July 29, 2024 18:07


          DG-1697: Added a new header


          DG-1697: Added a new header

b0daf47

arpit-at dismissed nikhilbonte21’s stale review via

b0daf47

July 29, 2024 12:38

arpit-at added 3 commits

August 5, 2024 12:14


          DG-1697: removed auto build feature

c91c3e9


          DG-1697: Renaming header to use x-atlan

4d2a284


          DG-1697: Renaming header to use x-atlan

85e3ed8

nikhilbonte21 requested changes

View reviewed changes

webapp/src/main/java/org/apache/atlas/web/rest/BusinessPolicyREST.java Show resolved Hide resolved


          DG-1697: Renaming header to use x-atlan

93cd03a

nikhilbonte21 approved these changes

View reviewed changes

arpit-at merged commit e50cc62 into master

4 of 5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet