Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DQ-165 Prevent user YAML override #3383

Merged
merged 2 commits into from
Oct 22, 2024
Merged

DQ-165 Prevent user YAML override #3383

merged 2 commits into from
Oct 22, 2024

Conversation

bichitra95
Copy link
Collaborator

@bichitra95 bichitra95 commented Aug 6, 2024 •
edited
Loading

Change description

Do not override the YAML the user provided. This will help retain the comments the user has added.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@bichitra95 bichitra95 changed the title DQ-165: Prevent user YAML override DQ-165 Prevent user YAML override Aug 6, 2024
@bichitra95 bichitra95 merged commit f2d0d05 into master Oct 22, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilbonte21 nikhilbonte21 nikhilbonte21 approved these changes

Assignees
No one assigned
Labels
READY FOR REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bichitra95 @nikhilbonte21