Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DG-1735 | Skip updating lastRefresh time on policy refresh failure for atlas service #3391

Merged
merged 3 commits into from
Aug 13, 2024
Merged

DG-1735 | Skip updating lastRefresh time on policy refresh failure for atlas service #3391

merged 3 commits into from
Aug 13, 2024

Conversation

krsoninikhil
Copy link

Change description

Description here

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@krsoninikhil
Skip updating lastRefresh time on failure
e6c0058
@krsoninikhil
Break refresh if ES is not synced
bb29a22 
Instead of proceeding with refreshing the atlas_tag policies,
this is will throw the exception so the last sync time is not
updated and next run again sees the audit logs
@krsoninikhil
Check audit logs based on event create time
fba51ff 
Previously used timestamp would never detect the delete event
as the entity update time doesn't get updated on delete
@krsoninikhil krsoninikhil changed the title Skip updating lastRefresh time on policy refresh failure for atlas service DG-1735 | Skip updating lastRefresh time on policy refresh failure for atlas service Aug 13, 2024
@krsoninikhil krsoninikhil merged commit 69c781b into beta Aug 13, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@krsoninikhil