Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG-1735 | Check last edit time only for authpoliy #3392

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

krsoninikhil
Copy link

@krsoninikhil krsoninikhil commented Aug 13, 2024

Without this check, policy download API check could take the Persona or Purpose update time to be last edit time for which it will not find a policy since no policy exist for this mistakenly considered timestamp.

Change description

Description here

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

Without this check, policy download API check could take the
Persona or Purpose update time to be last edit time
for which it will not find a policy since no policy
exist for this mistakenly considered timestamp.
@krsoninikhil krsoninikhil changed the title Check last edit time only for authpoliy DG-1735 | Check last edit time only for authpoliy Aug 13, 2024
@krsoninikhil krsoninikhil merged commit 8b51fda into beta Aug 13, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant