Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DG-1735 | Add retry while fetching auth policies #3394

Closed
wants to merge 10 commits into from
Closed

DG-1735 | Add retry while fetching auth policies #3394

wants to merge 10 commits into from

Conversation

krsoninikhil
Copy link

@krsoninikhil krsoninikhil commented Aug 14, 2024 •
edited
Loading

Change description

There were few cases reported where changes shown in audit logs for the policies created on a new connection creation where not reflecting while policies were fetched. This adds retries attempt with some delay to incorporate possible delay in ES sync with Cassandra.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@krsoninikhil
Check fetched policy time before updating cache
3c5d0f4
@krsoninikhil
Calculate lastEditTime from audit logs
5e17f01
@krsoninikhil
Try 3 times with a sleep if policies are missing
19ad495
@krsoninikhil
Add more logs
93b9bae
@krsoninikhil
Add check for atlas service on retry of policy refresh
f12370b
@krsoninikhil
Skip updating lastRefresh time on failure
e6c0058
@krsoninikhil
Break refresh if ES is not synced
bb29a22 
Instead of proceeding with refreshing the atlas_tag policies,
this is will throw the exception so the last sync time is not
updated and next run again sees the audit logs
@krsoninikhil
Check audit logs based on event create time
fba51ff 
Previously used timestamp would never detect the delete event
as the entity update time doesn't get updated on delete
@krsoninikhil
Check last edit time only for authpoliy
5faba35 
Without this check, policy download API check could take the
Persona or Purpose update time to be last edit time
for which it will not find a policy since no policy
exist for this mistakenly considered timestamp.
@krsoninikhil krsoninikhil marked this pull request as ready for review August 16, 2024 12:07
hr2904
hr2904 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@hr2904 hr2904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krsoninikhil
Copy link
Author

krsoninikhil commented Sep 9, 2024 •
edited
Loading

Closing this in favor of #3490

Context: https://atlanhq.slack.com/archives/C04V2SY5Y07/p1725545468059419?thread_ts=1723125152.921809&cid=C04V2SY5Y07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hr2904 hr2904 hr2904 approved these changes

@nikhilbonte21 nikhilbonte21 Awaiting requested review from nikhilbonte21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krsoninikhil @hr2904