Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIN-24 | Grant permissions to governance workflow client #3413

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

ChiragMadan1
Copy link

Change description

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@ChiragMadan1 ChiragMadan1 changed the title Grant permissions to governance workflow client WIN-24 | Grant permissions to governance workflow client Aug 22, 2024
jnkrmg
jnkrmg previously approved these changes Aug 22, 2024
@jnkrmg
Copy link

jnkrmg commented Aug 23, 2024

Make the changes suggested by @nikhilbonte21 in the beta branch as well as we merged it w/o these suggestions.

@ChiragMadan1 ChiragMadan1 merged commit 194ee0b into master Aug 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants