Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG-1773 | Fresh build issue due to outdated tests #3427

Merged
merged 10 commits into from
Aug 26, 2024

Conversation

krsoninikhil
Copy link

Change description

The build on master was breaking if all the cached files are removed and build is triggered fresh. Attached is the screenshot of the error. Apparently, some changes to the constructor of AtlasEntityStoreV2 class were made last month and there existed tests using this class. Not sure why the build never failed for author and others but only failed when maven cached files are deleted and fresh build was done.

image

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@krsoninikhil krsoninikhil merged commit 5883144 into beta Aug 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants