Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MESH-280 : Validation for dataProductAssetDSL attribute #3749

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

MESH-280 : Validation for dataProductAssetDSL attribute #3749

wants to merge 2 commits into from

Conversation

PRATHAM2002-DS
Copy link

@PRATHAM2002-DS PRATHAM2002-DS commented Nov 15, 2024 •
edited
Loading

Change description

Added validation for dataProductAssetDSL in product creation flow.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Screenshot

Screenshot 2024-11-15 at 9 57 26 PM (2)

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

sumandas0
sumandas0 previously approved these changes Nov 18, 2024
View reviewed changes
vedant-jain03
vedant-jain03 requested changes Nov 18, 2024
View reviewed changes
Copy link
Member

@vedant-jain03 vedant-jain03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PRATHAM2002-DS Let's also have a validation for assetCoverImage.

Reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedant-jain03 vedant-jain03 vedant-jain03 approved these changes

@sumandas0 sumandas0 sumandas0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PRATHAM2002-DS @sumandas0 @vedant-jain03