Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG-1893 Support append/remove/replace for Tags #3792

Merged
merged 5 commits into from
Dec 16, 2024
Merged

DG-1893 Support append/remove/replace for Tags #3792

merged 5 commits into from
Dec 16, 2024

Conversation

hr2904
Copy link
Collaborator

@hr2904 hr2904 commented Nov 27, 2024

Change description

Added support for sending explicit actions for tag append/update/remove
New payload schema looks like
with query param overrideClassifications=false
example URL : https://preview.atlan.com/api/meta/entity/bulk/setClassifications?overrideClassifications=false
When override is false, the appends/updates/removes array will be processed instead of the default classifications array.

{
    "guidHeaderMap": {
        "d762a137-2aa7-4916-ae67-cd8ba86d692c": {
            "guid": "d762a137-2aa7-4916-ae67-cd8ba86d692c",
            "typeName": "Schema",
            "attributes": {
                "name": "MYSQL_RDS_FIVETRAN_METADATA_API_CHINOOK",
                "qualifiedName": "default/snowflake/1703211402/FIVETRAN/MYSQL_RDS_FIVETRAN_METADATA_API_CHINOOK"
            },
            "appendClassifications": [
                {
                    "typeName": "KsEjhLQyJe1IK3WImU66T5",
                    "entityGuid": "d762a137-2aa7-4916-ae67-cd8ba86d692c",
                    "propagate": false,
                    "restrictPropagationThroughLineage": false,
                    "removePropagationsOnEntityDelete": false
                }
            ],
            "updateClassifications": [
                {
                    "typeName": "x7rq3qNdVO64e3RecLTkOr",
                    "entityGuid": "d762a137-2aa7-4916-ae67-cd8ba86d692c",
                    "propagate": false,
                    "restrictPropagationThroughLineage": true,
                    "removePropagationsOnEntityDelete": false
                }
            ],
            "removeClassifications": [
                {
                    "typeName": "lJE8o8eUyD3gP63CQl8s85",
                    "entityGuid": "d762a137-2aa7-4916-ae67-cd8ba86d692c",
                    "propagate": false,
                    "restrictPropagationThroughLineage": false,
                    "removePropagationsOnEntityDelete": false
                }
            ],
            "classifications": [
                {
                    "typeName": "FkVPzxQreHyRlrCbJTbdEQ",
                    "entityGuid": "d762a137-2aa7-4916-ae67-cd8ba86d692c",
                    "propagate": false,
                    "restrictPropagationThroughLineage": false,
                    "removePropagationsOnEntityDelete": false
                }
            ]
        }
    }
}

Type of change

  • New feature (adds functionality)

Related issues

Fix Ticket
TestCases

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable
    ](https://atlanhq.atlassian.net/wiki/x/LoBsHw)

nikhilbonte21
nikhilbonte21 previously approved these changes Dec 16, 2024
Copy link

@nikhilbonte21 nikhilbonte21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor comment regarding logging

@hr2904 hr2904 merged commit 14d38ed into master Dec 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants