Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MESH-299 | Audit Search Logs #3923

Merged
merged 5 commits into from
Dec 30, 2024
Merged

MESH-299 | Audit Search Logs #3923

merged 5 commits into from
Dec 30, 2024

Conversation

ankitpatnaik-atlan
Copy link
Collaborator

Change description

I have added the domain details for activity logs as per issue.

Type of change

  • Bug fix (fixes an issue)
  • [ x] New feature (adds functionality)

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

Screenshot 2024-12-27 at 11 07 01 AM (2)

if (guidKeys.contains(entry.getKey()) && entry.getValue() instanceof List) {
List<String> guids = (List<String>) entry.getValue();

if (guids != null && !guids.isEmpty()){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guids.isEmpty already checks for null and empty. Take a look at the documentation of the method and update this.

@ankitpatnaik-atlan ankitpatnaik-atlan changed the title Mesh-299-Audit Search Logs MESH-299-Audit Search Logs Dec 30, 2024
@ankitpatnaik-atlan ankitpatnaik-atlan changed the title MESH-299-Audit Search Logs MESH-299: Audit Search Logs Dec 30, 2024
@ankitpatnaik-atlan ankitpatnaik-atlan changed the title MESH-299: Audit Search Logs MESH-299 | Audit Search Logs Dec 30, 2024
Copy link
Collaborator

@hr2904 hr2904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankitpatnaik-atlan ankitpatnaik-atlan merged commit a824fa8 into beta Dec 30, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants