Skip to content

Commit

Permalink
enhancement(comment): remove deprecation callout from renderDownstrea…
Browse files Browse the repository at this point in the history
…mAssetsComment
  • Loading branch information
rittikdasgupta committed Nov 5, 2024
1 parent b141e99 commit 539ca05
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 20 deletions.
15 changes: 5 additions & 10 deletions dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -17945,26 +17945,19 @@ ${downstreamAssets.hasMore ? `[See more downstream assets at Atlan](${create_com
// Generating the "View asset in Atlan" button
const viewAssetButton = `${getImageURL("atlan-logo", 15, 15)} [View asset in Atlan](${create_comment_ATLAN_INSTANCE_URL}/assets/${asset.guid}/overview?utm_source=dbt_github_action)`;

// Deprecation callout
const deprecationCallout = `:warning: Deprecation Notice: This action is scheduled for deprecation and will no longer be supported after June 2025. To ensure a smooth transition and continued functionality, please migrate to atlan-action by following the migration guide available [here](https://ask.atlan.com/hc/en-us/articles/11121331752719).`

// Generating the final comment based on the presence of downstream assets
if (downstreamAssets.entities.length > 0) {
return `${assetInfo}

${downstreamTable}

${viewAssetButton}

${deprecationCallout}`;
${viewAssetButton}`;
} else {
return `${assetInfo}

No downstream assets found.

${viewAssetButton}

${deprecationCallout}`;
${viewAssetButton}`;
}
}

Expand All @@ -17988,8 +17981,10 @@ async function createIssueComment(octokit, context, content, comment_id = null,
const {pull_request} = context.payload;

// Deprecation callout
const deprecationCallout = `:warning: Deprecation Notice: This action is scheduled for deprecation and will no longer be supported after June 2025. To ensure a smooth transition and continued functionality, please migrate to atlan-action by following the migration guide available [here](https://ask.atlan.com/hc/en-us/articles/11121331752719).`
let deprecationCallout = `:warning: Deprecation Notice: This action is scheduled for deprecation and will no longer be supported after June 2025. To ensure a smooth transition and continued functionality, please migrate to atlan-action by following the migration guide available [here](https://ask.atlan.com/hc/en-us/articles/11121331752719).`

deprecationCallout = "\n\n---\n\n" + deprecationCallout;

content = `<!-- ActionCommentIdentifier: atlan-dbt-action -->
${content}

Expand Down
15 changes: 5 additions & 10 deletions src/utils/create-comment.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,26 +119,19 @@ ${downstreamAssets.hasMore ? `[See more downstream assets at Atlan](${ATLAN_INST
// Generating the "View asset in Atlan" button
const viewAssetButton = `${getImageURL("atlan-logo", 15, 15)} [View asset in Atlan](${ATLAN_INSTANCE_URL}/assets/${asset.guid}/overview?utm_source=dbt_github_action)`;

// Deprecation callout
const deprecationCallout = `:warning: Deprecation Notice: This action is scheduled for deprecation and will no longer be supported after June 2025. To ensure a smooth transition and continued functionality, please migrate to atlan-action by following the migration guide available [here](https://ask.atlan.com/hc/en-us/articles/11121331752719).`

// Generating the final comment based on the presence of downstream assets
if (downstreamAssets.entities.length > 0) {
return `${assetInfo}
${downstreamTable}
${viewAssetButton}
${deprecationCallout}`;
${viewAssetButton}`;
} else {
return `${assetInfo}
No downstream assets found.
${viewAssetButton}
${deprecationCallout}`;
${viewAssetButton}`;
}
}

Expand All @@ -162,8 +155,10 @@ export async function createIssueComment(octokit, context, content, comment_id =
const {pull_request} = context.payload;

// Deprecation callout
const deprecationCallout = `:warning: Deprecation Notice: This action is scheduled for deprecation and will no longer be supported after June 2025. To ensure a smooth transition and continued functionality, please migrate to atlan-action by following the migration guide available [here](https://ask.atlan.com/hc/en-us/articles/11121331752719).`
let deprecationCallout = `:warning: Deprecation Notice: This action is scheduled for deprecation and will no longer be supported after June 2025. To ensure a smooth transition and continued functionality, please migrate to atlan-action by following the migration guide available [here](https://ask.atlan.com/hc/en-us/articles/11121331752719).`

deprecationCallout = "\n\n---\n\n" + deprecationCallout;

content = `<!-- ActionCommentIdentifier: atlan-dbt-action -->
${content}
Expand Down

0 comments on commit 539ca05

Please sign in to comment.