Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection after failure handling #354

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

congwang09
Copy link
Contributor

Resolves: #352

Add connection after failure handling, and when successfully add connection back.

@coveralls
Copy link

coveralls commented Nov 8, 2024

Pull Request Test Coverage Report for Build 11799455388

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 56.828%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/handlers/connection_handler.py 0 3 0.0%
Totals Coverage Status
Change from base Build 11733936930: -0.06%
Covered Lines: 1107
Relevant Lines: 1948

💛 - Coveralls

Copy link
Contributor

@italovalcy italovalcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! thanks for sending this change to fix the issue, @congwang09 ! Very much appreciated!

@congwang09 congwang09 merged commit 4855ca1 into main Nov 12, 2024
11 checks passed
@congwang09 congwang09 deleted the save-connection-after-failure-handling branch November 12, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

L2VPN gets deleted during link down handler
3 participants