Review testing and ci #3268
Merged
Review testing and ci #3268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have often thought that we should source, cache, and host copies of all submodules to protect against failure and ensure complete reproducibility within our control. That is however beyond the discussion of this pull request. |
jmercouris
approved these changes
Dec 2, 2023
aartaka
approved these changes
Dec 4, 2023
The non-interactive flag is passed since compiling a program is done in a batch processing fashion.
As the documentation explains, it is unfinished work.
Commit 94bc828 introduces complexity for no good reason.
Deprecate "Keymap type checking" and "Validate make-instance symbols". Deprecate "Build Nyxt executable" since, in its current implementation, it's not clear whether it is produced. The generated binary can't be tried out locally since it is generated in an Ubuntu environment. Answers to questions such as "did the tests pass?" or "did it compile?" are more meaningful than "was the binary created?". Deprecate caching roswell since that job succeeds in a matter of seconds. The job that could benefit from caching is git submodule fetching.
aadcg
force-pushed
the
review-testing-and-ci
branch
from
43f208e to
e1eced0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #3262 (comment).
Discussion
The testing underlying these 2 reader macros entail loading the nyxt system, pushing them to
*features*and force loading the nyxt system again. This is not how a robust test suite should work.The features themselves are either under developed or were added as a workaround to deeper issues.
The commit messages provide extra details.