This repository has been archived by the owner on Mar 17, 2023. It is now read-only.
Update predicate #17
Closed
Update predicate #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing? |
jokeyrhyme
reviewed
Jun 12, 2018
| @@ -22,6 +22,8 @@ type ZapNameField func(name string) zap.Field | |||
| type Descriptor struct { | |||
| // Group Version Kind of objects a controller can process. | |||
| Gvk schema.GroupVersionKind | |||
| // IsInterestingUpdate is an optional predicate that is consulted before enqueuing an object on update event. | |||
| IsInterestingUpdate func(oldObj, newObj runtime.Object) bool | |||
There was a problem hiding this comment.
"Interesting" is fun, but I wonder if maybe something like ShouldUpdate() is more descriptive?
There was a problem hiding this comment.
Was going to comment the exact same thing before I saw your comment on another line 👍
benbarclay
approved these changes
Jun 14, 2018
|
I've been thinking about an alternative (more flexible) approach where we let the controller constructor attach whatever event handler it wants to use. Approach in this PR does not feel right, it is not generic enough... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16.